Support Set inspection in DWDS
#2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason we check in the generated |
annagrin
reviewed
Mar 9, 2023
| @@ -150,6 +151,11 @@ void printMap() { | |||
| print(map); // Breakpoint: printMap | |||
| } | |||
|
|
|||
| void printSet() { | |||
There was a problem hiding this comment.
I know we currently run those tests for sound null safety only, but I think we should keep the weak and sound project in sync (just in case:). Should we change the _testPackage/web/main to match?
There was a problem hiding this comment.
Done, added the test cases for lists, and maps as well
annagrin
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2001, flutter/devtools#5323
This PR adds support for
Setinspection in DWDS. Seems likeSetsupport was never added before.